Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a performance warning if containerd is enabled and we're exporting to the daemon #2284

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Nov 14, 2024

Addresses #2272 (comment) #1

(Potentially simpler) alternative to buildpacks/imgutil#285

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Nov 14, 2024
@github-actions github-actions bot added this to the 0.36.0 milestone Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (be2c8be) to head (1f7e0c8).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   69.21%   70.00%   +0.80%     
==========================================
  Files         252      254       +2     
  Lines       18656    18721      +65     
==========================================
+ Hits        12910    13104     +194     
+ Misses       4872     4741     -131     
- Partials      874      876       +2     
Flag Coverage Δ
os_linux 69.14% <28.58%> (-0.01%) ⬇️
os_macos-arm64 65.33% <35.72%> (-0.02%) ⬇️
os_windows 69.51% <28.58%> (?)
unit 70.00% <50.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@natalieparellano natalieparellano merged commit 92bc87b into main Nov 14, 2024
17 of 18 checks passed
@natalieparellano natalieparellano deleted the log/containerd branch November 14, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants