-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the condition for args [""] and no args[] #2248
Open
keshavdalmia10
wants to merge
4
commits into
buildpacks:main
Choose a base branch
from
keshavdalmia10:issue_#1283
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1023,3 +1023,67 @@ func testInspectImage(t *testing.T, when spec.G, it spec.S) { | |
}) | ||
}) | ||
} | ||
|
||
func TestArgumentParsing(t *testing.T) { | ||
spec.Run(t, "Argument Parsing", testArgumentParsing, spec.Parallel(), spec.Report(report.Terminal{})) | ||
} | ||
|
||
func testArgumentParsing(t *testing.T, when spec.G, it spec.S) { | ||
var ( | ||
mockController *gomock.Controller | ||
mockImageFetcher *testmocks.MockImageFetcher | ||
subject *Client | ||
out bytes.Buffer | ||
) | ||
|
||
it.Before(func() { | ||
mockController = gomock.NewController(t) | ||
mockImageFetcher = testmocks.NewMockImageFetcher(mockController) | ||
|
||
var err error | ||
subject, err = NewClient(WithLogger(logging.NewLogWithWriters(&out, &out)), WithFetcher(mockImageFetcher)) | ||
h.AssertNil(t, err) | ||
}) | ||
|
||
it.After(func() { | ||
mockController.Finish() | ||
}) | ||
|
||
when("inspecting images with different argument configurations", func() { | ||
it("properly displays the arguments", func() { | ||
images := map[string]string{ | ||
"imageNoArgs": `[]`, | ||
"imageEmptyArgs": `[""]`, | ||
"imageNonEmptyArgs": `["-p", "8080"]`, | ||
} | ||
|
||
for imageName, args := range images { | ||
mockImage := testmocks.NewImage(imageName, "", nil) | ||
h.AssertNil(t, mockImage.SetLabel("io.buildpacks.build.metadata", fmt.Sprintf(`{ | ||
"processes": [ | ||
{ | ||
"type": "web", | ||
"command": "/start/web-process", | ||
"args": %s, | ||
"direct": false | ||
} | ||
] | ||
}`, args))) | ||
|
||
mockImageFetcher.EXPECT().Fetch(gomock.Any(), imageName, gomock.Any()).Return(mockImage, nil).Times(1) | ||
|
||
info, err := subject.InspectImage(imageName, true) | ||
h.AssertNil(t, err) | ||
|
||
switch args { | ||
case `[]`: | ||
h.AssertEq(t, info.Processes.DefaultProcess.Args, []string{}) | ||
case `[""]`: | ||
h.AssertEq(t, info.Processes.DefaultProcess.Args, []string{""}) | ||
default: | ||
h.AssertEq(t, info.Processes.DefaultProcess.Args, []string{"-p", "8080"}) | ||
} | ||
Comment on lines
+1078
to
+1085
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is really testing our call to |
||
} | ||
}) | ||
}) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, we set this, but it is never actually used...