-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Google builder in the list of known builders. #2203
Conversation
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Co-authored-by: Ed Morley <[email protected]> Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Do we want to keep older builders as trusted but not suggested as we do with Heroku? I think the answer is no, but just wanted to double check, otherwise this one looks good to me |
For the Heroku builders, we've used the following methodology:
Given that the |
Summary
This PR updates the version of the Google builder in the KnownBuilders addressing #2199
In this PR, I have removed
gcr.io/buildpacks/builder:v1
from bothTrusted
andSuggested
. If there are criteria for beingTrusted
orSuggested
that require keeping v1, please let me know. I will be happy to make the necessary adjustments.Output
Before
pack builder suggest
pack config trusted-builders list
After
pack builder suggest
pack config trusted-builders list
Documentation
Related
Resolves #2199