Skip to content

Commit

Permalink
login to docker before pushing lifecycle image
Browse files Browse the repository at this point in the history
it seems that we were relying on a race condition of another job logging
into docker before we push/relocate the lifecycle image

Signed-off-by: Bohan Chen <[email protected]>
  • Loading branch information
chenbh committed Jul 25, 2023
1 parent ee3ed8d commit e36e3cb
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,20 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Docker Login
uses: docker/[email protected]
with:
registry: ${{ secrets.REGISTRY_HOST }}
username: ${{ secrets.REGISTRY_USER }}
password: ${{ secrets.REGISTRY_PASSWORD }}
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version-file: 'go.mod'
- name: Build
run: |
trap 'echo -e "$output"' EXIT
output=$(go run ./hack/lifecycle/main.go --tag=${{ env.PUBLIC_IMAGE_DEV_REPO }}/lifecycle 2>&1)
image=$(echo "$output" | grep "saved lifecycle" | awk -F "saved lifecycle image: " '{print $2}')
mkdir images
Expand Down

0 comments on commit e36e3cb

Please sign in to comment.