[issue-172] Adds flag success-build-history-limit and failed-build-history-limit
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbh
reviewed
Aug 28, 2023
|
I actually think we shouldn't set a default via the CLI, if the flag isn't provided, we should leave that field null. My opinion is that defaults should only be applied in one place, and that place is usually the kpack webhook controller. This way, the actual value can differ between kpack versions and in the distant future might even be configurable at the cluster level without ever having to upgrade the CLI. |
fcaroline2020
force-pushed
the
issue-172-support-build-history-limit-flag
branch
2 times, most recently
from
abfac5a
to
9e68bfe
Compare
|
To set values to null I had to change the |
chenbh
reviewed
Aug 30, 2023
fcaroline2020
force-pushed
the
issue-172-support-build-history-limit-flag
branch
from
d171c9d
to
5e0f509
Compare
fcaroline2020
force-pushed
the
issue-172-support-build-history-limit-flag
branch
from
5bde8d1
to
3f884dd
Compare
chenbh
approved these changes
Aug 31, 2023
|
@fcaroline2020 needs rebasing |
…description, adds both commands to `patch` Signed-off-by: Caroline Scherf <[email protected]>
fcaroline2020
force-pushed
the
issue-172-support-build-history-limit-flag
branch
from
3f884dd
to
7c4fe51
Compare
chenbh
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
success-build-history-limitandfailed-build-history-limitto image create, save, patchresolves #172
resolves #244