Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects reference to the kp-config configmap field default.repository.serviceaccount #330

Merged
merged 1 commit into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/kp_clusterbuildpack_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Create a cluster buildpack

Create a cluster buildpack by providing command line arguments.

The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.


```
Expand Down
2 changes: 1 addition & 1 deletion docs/kp_clusterstack_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Additionally, your cluster must have read access to the registry.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.


```
Expand Down
2 changes: 1 addition & 1 deletion docs/kp_clusterstack_patch.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Therefore, you must have credentials to access the registry on your machine.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.

```
kp clusterstack patch <name> [flags]
Expand Down
2 changes: 1 addition & 1 deletion docs/kp_clusterstack_save.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Additionally, your cluster must have read access to the registry.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.


```
Expand Down
2 changes: 1 addition & 1 deletion docs/kp_clusterstore_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Env vars can be used for registry auth as described in https://github.com/vmware

This clusterstore will be created only if it does not exist.
The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.


```
Expand Down
2 changes: 1 addition & 1 deletion docs/kp_clusterstore_save.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Env vars can be used for registry auth as described in https://github.com/vmware

This clusterstore will be created only if it does not exist, otherwise it will be updated.
The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.


```
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterbuildpack/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func NewCreateCommand(clientSetProvider k8s.ClientSetProvider, newWaiter func(dy
Short: "Create a cluster buildpack",
Long: `Create a cluster buildpack by providing command line arguments.

The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
`,
Example: `kp clusterbuildpack create my-cluster-buildpack --image gcr.io/paketo-buildpacks/java
kp clusterbuildpack create my-cluster-buildpack --image gcr.io/paketo-buildpacks/java:8.9.0
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterstack/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Additionally, your cluster must have read access to the registry.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
`,
Example: `kp clusterstack create my-stack --build-image my-registry.com/build --run-image my-registry.com/run
kp clusterstack create my-stack --build-image ../path/to/build.tar --run-image ../path/to/run.tar`,
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterstack/patch.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Therefore, you must have credentials to access the registry on your machine.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.`,
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.`,
Example: `kp clusterstack patch my-stack --build-image my-registry.com/build --run-image my-registry.com/run
kp clusterstack patch my-stack --build-image ../path/to/build.tar --run-image ../path/to/run.tar`,
Args: commands.ExactArgsWithUsage(1),
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterstack/save.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Additionally, your cluster must have read access to the registry.
Env vars can be used for registry auth as described in https://github.com/vmware-tanzu/kpack-cli/blob/main/docs/auth.md

The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
`,
Example: `kp clusterstack save my-stack --build-image my-registry.com/build --run-image my-registry.com/run
kp clusterstack save my-stack --build-image ../path/to/build.tar --run-image ../path/to/run.tar`,
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterstore/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Env vars can be used for registry auth as described in https://github.com/vmware

This clusterstore will be created only if it does not exist.
The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
`,
Example: `kp clusterstore create my-store -b my-registry.com/my-buildpackage
kp clusterstore create my-store -b my-registry.com/my-buildpackage -b my-registry.com/my-other-buildpackage
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/clusterstore/save.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Env vars can be used for registry auth as described in https://github.com/vmware

This clusterstore will be created only if it does not exist, otherwise it will be updated.
The default repository is read from the "default.repository" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
The default service account used is read from the "default.repository.serviceaccount" key in the "kp-config" ConfigMap within "kpack" namespace.
`,
Example: `kp clusterstore save my-store -b my-registry.com/my-buildpackage
kp clusterstore save my-store -b my-registry.com/my-buildpackage -b my-registry.com/my-other-buildpackage
Expand Down