Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Columns layout to respect space between columns #836

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

veej
Copy link
Member

@veej veej commented Mar 15, 2024

Strategy inspired by braid. Instead of using gap, we use a marginLeft on each column content (inside the column, so that it's taken into account in determining the width of the real content).

Tested successfully on collapse

I added a new story to verify that the behavior is consistent in different cases (both columns with an explicit width, explicit width + auto, explicit width + content, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant