Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: supporting zstd dictionary #4968

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions proto/remote_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2000,6 +2000,9 @@ message Compressor {

// Brotli compression.
BROTLI = 3;

// Zstandard compression with external dictionary support.
ZSTD_DICT = 4;
}
}

Expand Down Expand Up @@ -2036,6 +2039,24 @@ message CacheCapabilities {
// [BatchUpdateBlobs][build.bazel.remote.execution.v2.ContentAddressableStorage.BatchUpdateBlobs]
// requests.
repeated Compressor.Value supported_batch_update_compressors = 7;

// BUILDBUDDY EXTENSIONS BELOW

// A digest pointing to a [ZstdDictionaryRegistry][build.bazel.remote.execution.v2.ZstdDictionaryRegistry]
// object in CAS that contains the zstd dictionaries that should be used for
// compressing and decompressing blobs.
//
// This MUST be set if the server supports ZSTD_DICT compression.
Digest zstd_dictionary_registry = 1000;
}

message ZstdDictionaryRegistry {
// Each file's name should be set to either the dictID of the ZSTD dictionary (32 bits unsigned integer),
// or "default" for the default dictionary that client SHOULD use to compress uploaded data.
//
// A "default" dictionary MUST always be present.
// The server MUST ensure that all listed dictionaries are accessible throughout the invocation duration.
repeated FileNode dictionaries = 1;
}

// Capabilities of the remote execution system.
Expand Down