-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro button style changes #342
base: master
Are you sure you want to change the base?
Conversation
Visually, I prefer the fixed width buttons in a grid. But, this does let you use longer names. My intent was that the user would be forced to used names that fit like. Another idea is to scale the text automatically to fit. I wasn't sure if this was possible at first but there is a way using SVG. We would go back to the grid and replace the text in the button with something like this: <svg viewBox="0 0 56 18">
<text x="0" y="15">Rotary Laser</text>
</svg> Actually we would need to change a line in
To:
I'm not sure what the numbers above should be.
The hope would be that the font just shrinks as the text gets longer but the button stays the same size. Totally untested though. |
I'm not really a fan of different size text on a page as the text is the focal point and provides relative info to the user. I understand the uniformity of button sizes, but being a production user, functionality and ease of use is priority to me. Obviously this is your project to choose which direction to go, but I definitely can't help with the css/svg setup, as that is way over my head. |
569814f
to
0951758
Compare
What about this version?
It leaves the overflow hidden and sets a button width.
Desktop view:
Mobile view: