Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maze-runner tests from v1 to v9 #244

Merged
merged 23 commits into from
Aug 27, 2024
Merged

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Aug 21, 2024

Goal

With updated Github ubuntu images our maze-runner tests were failing and one test app wasn't building.
Here we updated test fixtures from v1 to v9.

Changeset

Feature steps updated, three test apps merged into one, removed test cases that were mostly testing old test engine.
Updated test app's Dockerfile to properly download modules (previously for go 1.11 and 1.12 all packages were in latest versions).

Testing

Changed all mazerunner tests, unit tests related to prefixed headers.

DariaKunoichi and others added 21 commits August 20, 2024 12:49
Prepare CI for new mazerunner tests, use GO111MODULE for older golang…
Add integrity header, change to command pattern in test app
Separate test functions into scenarios
Remove autoconfig and nethttp test apps
Rewrite test features to new steps
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nicely thought through and a good reason, modernising the test setup.

@DariaKunoichi DariaKunoichi changed the title Update maze-runner tests from v1 to v9, add integrity header Update maze-runner tests from v1 to v9 Aug 22, 2024
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me 👍

@DariaKunoichi DariaKunoichi merged commit 47533b2 into next Aug 27, 2024
53 checks passed
@DariaKunoichi DariaKunoichi deleted the integration/mazerunnerv9 branch August 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants