-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maze-runner tests from v1 to v9 #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare CI for new mazerunner tests, use GO111MODULE for older golang…
Add integrity header, change to command pattern in test app
Separate test functions into scenarios
Remove autoconfig and nethttp test apps
Enable CI tests for ubuntu
Rewrite test features to new steps
twometresteve
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nicely thought through and a good reason, modernising the test setup.
DariaKunoichi
changed the title
Update maze-runner tests from v1 to v9, add integrity header
Update maze-runner tests from v1 to v9
Aug 22, 2024
Remove Bugsnag-Integrity header
tomlongridge
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
With updated Github ubuntu images our maze-runner tests were failing and one test app wasn't building.
Here we updated test fixtures from v1 to v9.
Changeset
Feature steps updated, three test apps merged into one, removed test cases that were mostly testing old test engine.
Updated test app's Dockerfile to properly download modules (previously for go 1.11 and 1.12 all packages were in
latest
versions).Testing
Changed all mazerunner tests, unit tests related to prefixed headers.