Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate test functions into scenarios #240

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

DariaKunoichi
Copy link
Contributor

@DariaKunoichi DariaKunoichi commented Aug 20, 2024

Test cases from autoconfig test app moved into autoconfig_scenario.
Same for nethttp app - it's moved to nethttp_scenario.
Those test apps will be removed later.

@DariaKunoichi DariaKunoichi self-assigned this Aug 20, 2024
@DariaKunoichi DariaKunoichi changed the base branch from integrity_header to integration/mazerunnerv9 August 20, 2024 14:13
@DariaKunoichi DariaKunoichi changed the base branch from integration/mazerunnerv9 to integrity_header August 20, 2024 17:34
Base automatically changed from integrity_header to integration/mazerunnerv9 August 21, 2024 08:45
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - my comments are only suggestions for the future and to check that one function was intentionally removed - which I suspect it was (or I have just missed it).

features/fixtures/app/main.go Show resolved Hide resolved
features/fixtures/app/main.go Show resolved Hide resolved
@DariaKunoichi DariaKunoichi merged commit dd819fa into integration/mazerunnerv9 Aug 21, 2024
26 checks passed
@DariaKunoichi DariaKunoichi deleted the scenarios branch August 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants