Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vitess's fork of goyacc, which uses more efficient token union type #135

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhump
Copy link
Member

@jhump jhump commented May 1, 2023

This is just a draft because I don't want to actually merge in its current form.

We'd need to make a decision about whether to use --fast-append mode (an optimization intended to counter the fact that the use of an interface type means that non-pointer types are still allocated on the heap, including slices where the slice headers get allocated on the heap) or to wrap all of the slice types in the union in single-field structs (so the value in the interface is a pointer, and there won't be other unintentional allocations of non-pointer types).

If we go with the former, the "unsafe" import is required. But that seems not-great for portability. However, the second approach doesn't immediately let us remove the "unsafe" import until this bug is fixed.

@jhump
Copy link
Member Author

jhump commented May 1, 2023

cc @pkwarren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant