Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project environement and user count organization list API #1244

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

Ubisoft-potato
Copy link
Collaborator

@Ubisoft-potato Ubisoft-potato commented Sep 18, 2024

This PR will add project environement and user count for ListOrganizations API to adpat new dashboard UI.

Key changes:

  1. Update SQL query
  2. Add fields to proto file

@Ubisoft-potato Ubisoft-potato marked this pull request as ready for review September 18, 2024 07:30
Comment on lines 31 to 33
int32 projects = 11;
int32 environments = 12;
int32 users = 13;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int32 projects = 11;
int32 environments = 12;
int32 users = 13;
int32 projects_count = 11;
int32 environments_count = 12;
int32 users_count = 13;

Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cre8ivejp cre8ivejp merged commit d6cb3d6 into main Sep 18, 2024
16 checks passed
@cre8ivejp cre8ivejp deleted the feat-organization branch September 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants