Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscriber metric name #1186

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: subscriber metric name #1186

merged 1 commit into from
Aug 6, 2024

Conversation

cre8ivejp
Copy link
Member

@cre8ivejp cre8ivejp commented Aug 6, 2024 •
edited
Loading

Because the Subsystem is a subscriber, the metric name should not include the subscriber prefix.

@cre8ivejp
fix: subscriber metric name
2779654 
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
@cre8ivejp cre8ivejp marked this pull request as ready for review August 6, 2024 02:13
Ubisoft-potato
Ubisoft-potato approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@Ubisoft-potato Ubisoft-potato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cre8ivejp cre8ivejp merged commit 2385042 into main Aug 6, 2024
13 checks passed
@cre8ivejp cre8ivejp deleted the fix-subscriber-metrics branch August 6, 2024 02:21
@bucketeer-bot bucketeer-bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ubisoft-potato Ubisoft-potato Ubisoft-potato approved these changes

@kentakozuka kentakozuka Awaiting requested review from kentakozuka kentakozuka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cre8ivejp @Ubisoft-potato