chore: unify web-gateway and backend #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubisoft-potato
force-pushed
the
chore-combine-backend
branch
from
a4f7e19
to
828bfc9
Compare
Ubisoft-potato
force-pushed
the
chore-combine-backend
branch
2 times, most recently
from
d8d85d1
to
0c1860d
Compare
cre8ivejp
reviewed
Aug 6, 2024
cre8ivejp
reviewed
Aug 7, 2024
cre8ivejp
reviewed
Aug 7, 2024
Comment on lines
+14
to
+18
| mysqlUser: | ||
| mysqlPass: | ||
| mysqlHost: | ||
| mysqlPort: 3306 | ||
| mysqlDbName: |
There was a problem hiding this comment.
I couldn't find the mysqlDbOpenConns value.
There was a problem hiding this comment.
We only added mysqlDbOpenConns for subscribers before, we can add it here if needed.
cre8ivejp
reviewed
Aug 7, 2024
Ubisoft-potato
force-pushed
the
chore-combine-backend
branch
from
88ec96f
to
e477d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unify
web-gatewayandbackendservice charts to one service:web.