Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move subscribers to new service #1168

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

Ubisoft-potato
Copy link
Collaborator

@Ubisoft-potato Ubisoft-potato commented Jul 30, 2024

Part of #405

This PR will remove all subscribers from the batch service and then establish a service named subscriber. This allows for separate management of all subscribers.

Key changes

  • Remove subscribers from batch service.
  • Create subscriber service. [1] [2]
  • We don't need ingress in subscriber service envoy config. [1]

@Ubisoft-potato Ubisoft-potato marked this pull request as ready for review July 30, 2024 08:00
@cre8ivejp
Copy link
Member

@Ubisoft-potato, please fix the conflict.

@Ubisoft-potato
Copy link
Collaborator Author

@Ubisoft-potato, please fix the conflict.

Fixed!

Copy link
Contributor

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cre8ivejp cre8ivejp merged commit d97f383 into main Aug 5, 2024
19 checks passed
@cre8ivejp cre8ivejp deleted the chore-move-subscribers branch August 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants