Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ops event rate not being processed #1164

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: ops event rate not being processed #1164

merged 1 commit into from
Jul 26, 2024

Conversation

cre8ivejp
Copy link
Member

@cre8ivejp cre8ivejp commented Jul 26, 2024

Things done

  • Fixed count query
  • Updated e2e tests to use the correct ops_type and and action_type when testing event rate operations.

Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
@@ -28,7 +28,7 @@ var (
)

type AutoOpsRuleStorage interface {
CountNotTriggeredAutoOpsRules(ctx context.Context) (int, error)
CountOpsEventRate(ctx context.Context) (int, error)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the interface because the meaning was incorrect.

@cre8ivejp cre8ivejp marked this pull request as ready for review July 26, 2024 07:43
@cre8ivejp cre8ivejp requested review from kakcy and removed request for kentakozuka July 26, 2024 07:43
Copy link
Contributor

@kakcy kakcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@cre8ivejp cre8ivejp merged commit 835ef0a into main Jul 26, 2024
32 of 40 checks passed
@cre8ivejp cre8ivejp deleted the fix-count-query branch July 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants