Skip to content

Commit

Permalink
chore: dev container performance (#1118)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ubisoft-potato authored Jul 11, 2024
1 parent 0f70605 commit 3834dd4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,10 @@ build-devcontainer:

# start minikube
start-minikube:
if [ $$(minikube status | grep -c "minikube start") -eq 1 ]; then \
if [ $$(minikube status | grep -c "kubelet: Running") -eq 1 ]; then \
echo "minikube is already running"; \
exit 1; \
elif [ $$(minikube status | grep -c "minikube start") -eq 1 ]; then \
make -C tools/dev setup-minikube; \
elif [ $$(minikube status | grep -c "Stopped") -gt 1 ]; then \
make -C tools/dev start-minikube; \
Expand Down
2 changes: 1 addition & 1 deletion tools/dev/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ oauth-key-secret:
kubectl create secret generic bucketeer-oauth-key --from-file public.pem=${CURDIR}/cert/oauth-public.pem --from-file private.pem=${CURDIR}/cert/oauth-private.pem --namespace $(NAMESPACE)

setup-minikube:
minikube start --memory 6g
minikube start --memory max --cpus max
minikube addons enable ingress
kubectl patch deployment -n ingress-nginx ingress-nginx-controller --type='json' -p='[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value":"--enable-ssl-passthrough"}]'
helm install localenv ../../manifests/localenv
Expand Down

0 comments on commit 3834dd4

Please sign in to comment.