Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loop-function): handle async or generator function #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vitorveiga
Copy link
Contributor

Hello,

Transpiling the following snippet with options generator and asyncAwait disabled:

function* foo() {
  do {
    yield 1;
    const b = "string";

    function x() {
      console.log(b);
    }

    x();
  } while (1);
}

the result is:

function* foo() {
    var loop = function () {
        yield 1;
        var b = "string";

        function x() {
            console.log(b);
        }

        x();
    };
    do {
        loop();
    } while (1);
};

Evaluating the transpiled code, a Syntax Error occur due to the missing '*' in loop function.

Note: Same behaviour in async functions.

@vitorveiga vitorveiga closed this Sep 30, 2019
@vitorveiga
Copy link
Contributor Author

Semantically different. Working on a possible solutions.

@vitorveiga vitorveiga reopened this Sep 30, 2019
@vitorveiga
Copy link
Contributor Author

In order to be semantically equal, it was add await loop() for async function and yield* for generator functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant