Co-authored-by: Steven Lambert <[email protected]>

* docs(frameMessenger): clarify advanced use cases

* chore: address feedback

* Update doc/frame-messenger.md

Co-authored-by: Steven Lambert <[email protected]>

* Update axe.d.ts

Co-authored-by: Dan Bjorge <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Dan Bjorge <[email protected]>

* fix(sri-history): add backported releases

* Update sri-history.json

* Update sri-history.json

Co-authored-by: Steven Lambert <[email protected]>

…s (#3015)

* docs: clarify axe.run options paramter does not modify rules or checks

* Update doc/API.md

Co-authored-by: Cassey Lottman <[email protected]>

Co-authored-by: Cassey Lottman <[email protected]>

* chore: downgrade npm to v6 and regenerate package-lock

* fix chromedriver

* minor corrections and addition of new constants

* various corrections to clarify meaning or remove linguistic errors

* Update locales/pl.json

Co-authored-by: Aron Janecki <[email protected]>

Co-authored-by: Aron Janecki <[email protected]>

* fix(accText): ignore text in embedded content elements

Closes  #3017

* Update lib/standards/html-elms.js

* Update lib/standards/html-elms.js

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>

… just parents (#2980)

* ci: fix chrome nightly test

* who know

* fix

…rue (#2987)

* fix(publish-metadata): use fail message for rules with reviewOnFail:true

* revert

* fix tests

… (#2986)

* docs(rule-descriptions): don't mark as failure if reviewOnFail is set

* fix

* undo change

* chore(VirtualRule): add nodeIndex property

* chore(DqElement): add nodeIndexes

* chore(DqElement): fix up fromFrame

* chore(dqelement): fix for IE

* chore(mergeResult): merge using nodeIndex

* chore: formatting

* chore: fix iframe order sorting

* chore: resolve feedback

* chore(merge-results): deal with invalid nodeIndexes

* chore: more tests

* chore: consistent node sorting

* chore: more fun with sorting

* fix(merge-results): handle invalid nodeIndexes

* fix: nodeIndex can be 0

* Update lib/core/utils/dq-element.js

* bump up height requirement for sr-only to 1px

* add special case for sr-only method

* use less than 2

Co-authored-by: Wilco Fiers <[email protected]>

* make if smaller

Co-authored-by: Wilco Fiers <[email protected]>

* fix(frame-tested): run without respondable

* revert playground and files

* add after tests

* work with shadow dom

* fixes

* show undefined for all tests

Co-authored-by: Steven Lambert <[email protected]>

* docs(frameMessenger): clarify advanced use cases

* chore: address feedback

* Update doc/frame-messenger.md

Co-authored-by: Steven Lambert <[email protected]>

* Update axe.d.ts

Co-authored-by: Dan Bjorge <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Dan Bjorge <[email protected]>

* fix(sri-history): add backported releases

* Update sri-history.json

* Update sri-history.json

Co-authored-by: Steven Lambert <[email protected]>

…s (#3015)

* docs: clarify axe.run options paramter does not modify rules or checks

* Update doc/API.md

Co-authored-by: Cassey Lottman <[email protected]>

Co-authored-by: Cassey Lottman <[email protected]>

* chore: downgrade npm to v6 and regenerate package-lock

* fix chromedriver

* minor corrections and addition of new constants

* various corrections to clarify meaning or remove linguistic errors

* Update locales/pl.json

Co-authored-by: Aron Janecki <[email protected]>

Co-authored-by: Aron Janecki <[email protected]>

* fix(accText): ignore text in embedded content elements

Closes  #3017

* Update lib/standards/html-elms.js

* Update lib/standards/html-elms.js

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>

chore(release): 4.2.3

…frame itself is in a region (#2949)

* only run region rule on initiatior; iframe results will be on their own reports

* add test

* content in iframes that are in regions should be counted as within the region

* add another nested iframe test

* move match ancestry function to shared file

* attempt to move things forward

* working now

* remove test that won't work because that logic is in the after method now

* add unit tests for after method

* test only result

* match ancestry tests

* passes

* add comment

* refactor

* more refactor

* add additional test

chore: merge master

…ore pseudo elements entirely (#3016)

* add ignorePseudo option

* ignorePseudo option works

* ignore pseudo elements in color contrast if they are not visible

* add tests for new pseudo option and checks

* Update doc/check-options.md

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>

…re used on element with no implicit role (#2989)

* feat(utils): add getFrameContexts method

* updates

* finish tests

* better

* revert playground

* fix ie11

* Update lib/core/base/context.js

Co-authored-by: Wilco Fiers <[email protected]>

* Update lib/core/public/load.js

Co-authored-by: Wilco Fiers <[email protected]>

* tests

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Steven Lambert <[email protected]>

…ader elements (#3028)

* use aria-level on headings in addition to role=header elements

* account for more cases

* use heading level if aria-level is invalid on a hn tag

* remove console log

Co-authored-by: Wilco Fiers <[email protected]>

* update comment

Co-authored-by: Steven Lambert <[email protected]>

* remove comment

Co-authored-by: Steven Lambert <[email protected]>

* allow heading levels above 6

Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Steven Lambert <[email protected]>

…036)

* initial setup of NodeNamesToTypesEnum, if-statements, and assert

* comment for NodeNamesToTypesEnum enum

* const -> let: 223 tests completed

* not sure if needed but this was an auto-generated change

* correction: 1 -> 11

* add test for serial-virtual-node.js

* clean up nodeNamesToTypes

* simplify getting nodeType and nodeName, as per PR suggestion

* remove unnecessary assert

Co-authored-by: Steven Lambert <[email protected]>

* reorder for aesthetic clarity

* add test (ignores nodeType 1): defaults to the correct nodeName for certain nodeTypes

* fix: can't .toLowerCase after setting const

* fix tests: does not throw if nodeType is falsy because nodeType defaults to 1

* fix Object.values not supported in IE 11.0 Windows 10

* try to fix tests timing issue

Co-authored-by: Steven Lambert <[email protected]>

* chore(aria-hidden-body): fix broken test

* chore(getFrameContexts): include all context info

* chore: inline getBoundingSize

…g clip should be not visible (#3038)

* only count as not visible because of clip when absolutely positioned

* update tests

…s as potential duplicates (#3051)

* perf(core/virtual-node): cache node properties

`props` is being accessed frequently. Returning a new object for every
access results in unnecessary overhead due to the memory allocation and
the subsequent garbage collection.

Tests that relied on mutating private fields have been updated.

Benchmarking with `hyperfine --warmup 1 'axe https://www.dr.dk/'` shows
a reduction in running time of ~400ms.

* perf(core/matchExpressions): avoid array allocation inside hot loop

There is no need to allocate a new array to iterate over the members of
two arrays.

This patch switches the iteration logic to use an index for reading from
both arrays. Added a test for this code-path.

* perf(core/matchesExpression): avoid allocating memory

`matchesExpression` is a recursive function that processes the
`expressions` array one item at a time (`exps.pop()`). It currently
allocates a new array for each recursive call, which is unnecessary.

This patch introduces another parameter (`index`) to keep track of the
expression to match on, thus avoiding the memory allocation. The bulk
of the logic is moved to another function (`optimizedMatchesExpression`)
to keep the same parameters for the exported function
(`matchesExpression`).

Benchmarking with `hyperfine --warmup 1 'axe https://www.dr.dk/'` shows
a reduction in running time of ~400ms.

* perf(core/matchExpressions): avoid allocating memory

There is no need to copy and reverse `vNodes` - an index can be used to
keep track of the current node.

* perf(core/matchExpressions): recycle local variables

Avoid allocating new object for during every call to
`createLocalVariables`. Sharing `recycledLocalVariables` between calls
to `matchExpressions` is safe due to the fact that `axe-core` runs in
a single thread.

Benchmarking with
`hyperfine --warmup 1 'axe https://www.theguardian.com/international'`
shows a reduction in running time of ~80ms.

* perf(core/matchExpressions): avoid array allocations

Initialize `childOnly` and `childAny` with `null` and only create new
arrays when adding data for the first time.

Co-authored-by: Sorin Davidoi <[email protected]>

* chore(aria-hidden-body): fix broken test

* chore(getFrameContexts): include all context info

* chore: inline getBoundingSize

* chore: runPartial WIP

* feat(runPartial): Test without frame communication

* finsh run tests

* chore: complete finishRun tests

* chore: linting / formatting

* fix: cache.delete does not exist

* chore: tweaks

* chore: minor updates

Co-authored-by: Steven Lambert <[email protected]>

* add missing iframe loading waits

* add testutils where needed

* remove textbox from aria-required-children for combobox

* aria-required-attr changes for combobox

* address PR comments

* hardcode combobox owned roles

* fix another test

* use ariaAttrs.has-popup.values instead of hardcoded  list

* add comment

* add aria-owns attribute

* fix test

* chore: allow aria-valid-attr-value to run virtually

* finish tests

* Update lib/checks/aria/aria-errormessage.json

Co-authored-by: Wilco Fiers <[email protected]>

* Update lib/commons/aria/validate-attr-value.js

Co-authored-by: Wilco Fiers <[email protected]>

* suggestions

* Update lib/checks/aria/aria-valid-attr-value-evaluate.js

Co-authored-by: Wilco Fiers <[email protected]>

Co-authored-by: Wilco Fiers <[email protected]>

* chore: allow aria-allowed-role to run virtually

* chore: allow aria-allowed-role to run virtually

* revert is-visible

* finished

* fix

* Update lib/core/utils/is-html-element.js

Co-authored-by: Wilco Fiers <[email protected]>

* Update lib/commons/aria/get-element-unallowed-roles.js

Co-authored-by: Wilco Fiers <[email protected]>

* Update test/checks/aria/aria-allowed-role.js

Co-authored-by: Wilco Fiers <[email protected]>

* add test

Co-authored-by: Wilco Fiers <[email protected]>

* chore(d.ts): type runPartial + finishRun

* Apply suggestions from code review

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Stephen Mathieson <[email protected]>

* chore: fix issues with return types

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Stephen Mathieson <[email protected]>

* new aria-level check works

* add test

* fix integration tests

* fix tests

…(#3068)

* fix(utils): unify use of getFrameContexts

Adds axe.utils.shadowSelect to find frames from getFrameContext()

* Apply suggestions from code review

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>

* use text shadow as foreground color if foreground is transparent

* typos

* fix(color-contrast) Zero size text shadow should not be included as background color (#3014)

* add test for shadows when offsets are greater than blur

* put back playground

* blend in foreground color with text shadow and bg when fg alpha < 1

* update order

* Use more specific failure messages for color contrast failures (#3010)

* use more specific failure messages for color contrast failures

* fix logic & add tests

* use default as message key for fgOnBgColor

* improve messages

* add test for all 3 blended colors

* format string

Co-authored-by: Wilco Fiers <[email protected]>

* format string

Co-authored-by: Wilco Fiers <[email protected]>

* use shadow color flattened

Co-authored-by: Wilco Fiers <[email protected]>

* docs(runPartial): recommendations on runPartial / finishRun.

* Apply suggestions from code review

Co-authored-by: Steven Lambert <[email protected]>

* Update doc/run-partial.md

* Update doc/run-partial.md

Co-authored-by: Steven Lambert <[email protected]>

chore(release): 4.3.0

chore(release): 4.3.1

chore: merge master

…have focusable children (#3056)

* fieldset that's hidden and disabled should mean input inside is not focusable

* only return true if elements are in same shadow tree

* use break

* fix performance issue

* change target to fieldset element

* do caching better

* fix return value

* more caching

* add test

* stop mutating

* does not mutate inputs

* cleanup

* clone another way

* remove temp variable

* don't deep clone dom nodes

* remove console log

* add comment

Co-authored-by: Stephen Mathieson <[email protected]>

* check if window exists

Co-authored-by: Steven Lambert <[email protected]>

* clone all at once at first

* also allow instanceof HTMLCollection for ie11

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Stephen Mathieson <[email protected]>
Co-authored-by: Steven Lambert <[email protected]>

…s if group is present (#3084)

…true (#3089)

* fix(aria-required-attr): only require aria-controls if aria-expanded=true

* fix tests

* fix for modified standads

…(#3088)

* fix(run,finishRun): don't mutate options, set default reporter to v1

* normalize options in runOnly

* fix test

…#3097)

* fix(color-contrast): check for size before ignoring pseudo elements

* chore(eslint): disable no-use-bef-re-define

* chore: tweak tests for IE

* chore: address IE11 problem

* Apply suggestions from code review

Co-authored-by: Steven Lambert <[email protected]>

* chore: tweak

* Update lib/checks/color/color-contrast-evaluate.js

Co-authored-by: Steven Lambert <[email protected]>

Co-authored-by: Steven Lambert <[email protected]>

Release 4.3.2

chore: merge master into develop

…utes on elements without a role (#3102)

* feat(aria-allowed-attr): report violations for non-global ARIA attributes on elements without a role

* fix tests

* remove wrong test

* tests: locally host webfonts for is-icon-ligature test

* license

* chore: use standards in aria-supported script

* fixes

* chore(i18n): updated french translation

* integrated proofreading by @audreymaniez

* translation improvement after discussion with @audreymaniez

* chore(i18n) Update Korean locale translate

- Update translation based on currently develop branch
- Change some of existing translation to make it easier to understand

Closes issuse: N/A

* First correction to reviews

* fixed incorrect notaions

* fixed missed incorrect notaions

- tabindex-1가 -> tabindex=-1이

* fix missed incorrect notations

- 반드시 없어야 합니다 -> 존재하지 않아야 합니다

* fix missed incorrect notations

- 큰 테이블의 각 비어 있지 않은 데이터 셀이 -> 큰 테이블의 비어 있지 않은 각 데이터 셀이
- 그들이 -> 그것들이
- 의미론 역할 -> 의미론적 역할
- 제공하세요 -> 제공되지 않았습니다

* I reflected the latest changes additionally

* tests: put back autocomplete-valid act tests

* chache bust npm

* always run latest

* Update .circleci/config.yml

Co-authored-by: Wilco Fiers <[email protected]>

Co-authored-by: Wilco Fiers <[email protected]>

…es (#3124)

* fix(aria-allowed-role): Update allowed roles based on ARIA spec updates

* `<b>` now allows any roles
* `<nav>` now also allows `menu`, `menubar`, `tablist`
* `<svg>` now allows any roles

Based on ARIA spec: https://www.w3.org/TR/html-aria/

* fix(aria-allowed-role): Update progress element to not allow any roles

Co-authored-by: Timo Gasda <[email protected]>

This PR sets the axe reporters up so they can run without access to the top-level browsing context. This is needed so that `axe.finishRun()` can be called outside the context of a web page.

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Stephen Mathieson <[email protected]>
Co-authored-by: Steven Lambert <[email protected]>

* tests: locally host webfonts for is-icon-ligature test

* license

* chore: use standards in aria-supported script

* fixes

* chore(i18n): updated french translation

* integrated proofreading by @audreymaniez

* translation improvement after discussion with @audreymaniez

* tests: put back autocomplete-valid act tests

* chache bust npm

* always run latest

* Update .circleci/config.yml

Co-authored-by: Wilco Fiers <[email protected]>

Co-authored-by: Wilco Fiers <[email protected]>

…es (#3124)

* fix(aria-allowed-role): Update allowed roles based on ARIA spec updates

* `<b>` now allows any roles
* `<nav>` now also allows `menu`, `menubar`, `tablist`
* `<svg>` now allows any roles

Based on ARIA spec: https://www.w3.org/TR/html-aria/

* fix(aria-allowed-role): Update progress element to not allow any roles

Co-authored-by: Timo Gasda <[email protected]>

This PR sets the axe reporters up so they can run without access to the top-level browsing context. This is needed so that `axe.finishRun()` can be called outside the context of a web page.

Co-authored-by: Steven Lambert <[email protected]>
Co-authored-by: Stephen Mathieson <[email protected]>
Co-authored-by: Steven Lambert <[email protected]>

chore(release): 4.3.3