Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool.end() resolves before the last pool.query() #3254

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

pool.end() resolves before the last pool.query() #3254

wants to merge 6 commits into from

Conversation

asadbek2021
Copy link

@asadbek2021 asadbek2021 commented Jun 11, 2024 •
edited
Loading

Here is the link to the issue: 2163

@brianc
Copy link
Owner

brianc commented Jun 14, 2024

Hey - this is awesome, thank you! Sorry for the delay - I'm in the mountains in colorado until Monday so i'm a bit slow to respond. Will be a lot more avail when I get home...but thanks so much for fixing/improving this. been a long-standing little bug...nice to get it taken care of! ❤️

@asadbek2021
Copy link
Author

Hi! I should add some corrections though, now two other tests seem not passing so I will fix it

@asadbek2021
fix: test resolve should be called when the last client is removed
e81fc3d
@asadbek2021
fix: wait for pool.end()
5e91617 
Because when you don't pass a callback to .end() it always returns a promise
@brianc
Copy link
Owner

brianc commented Jun 18, 2024

Hi! I should add some corrections though, now two other tests seem not passing so I will fix it

Howdy - looks like one of the tests for idle timeout still isn't passing - you still lookin' into that?

@asadbek2021
Copy link
Author

Hi! I should add some corrections though, now two other tests seem not passing so I will fix it

Howdy - looks like one of the tests for idle timeout still isn't passing - you still lookin' into that?

Yeah, I am trying to figure out what's wrong with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asadbek2021 @brianc