Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spider diagrams #59

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Spider diagrams #59

merged 4 commits into from
Dec 22, 2023

Conversation

RowanGregoire
Copy link
Contributor

Add spider diagrams to the plotting extension.

@brenhinkeller
Copy link
Owner

Great! Want to add a quick test along the lines of the one for mapplot in https://github.com/brenhinkeller/StatGeochem.jl/blob/main/test/testExtensions.jl?

@RowanGregoire RowanGregoire marked this pull request as draft December 21, 2023 21:51
@RowanGregoire RowanGregoire marked this pull request as ready for review December 21, 2023 21:52
@brenhinkeller
Copy link
Owner

Oh so exporting things from package extensions is weird.. if the function you want to add doesn't already exist in the main package, you have to first export a dummy method from the main package (e.g.

# Methods exclusively for package extensions
mapplot() = @warn "`mapplot` requires Plots.jl"
mapplot!() = @warn "`mapplot!` requires Plots.jl"
export mapplot, mapplot!
for mapplot), and then import and re-export that in the extension

@RowanGregoire
Copy link
Contributor Author

Oh I got so close to getting that right

@brenhinkeller brenhinkeller merged commit 422b7bf into brenhinkeller:main Dec 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants