Skip to content

Commit

Permalink
fix(test): file.spec.131 moveTo may fail due to read order assumption
Browse files Browse the repository at this point in the history
  • Loading branch information
breautek committed Nov 3, 2024
1 parent 953e653 commit 1a4e3d9
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions tests/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -1941,8 +1941,18 @@ exports.defineAutoTests = function () {
directoryReader.readEntries(function successRead (entries) {
expect(entries.length).toBe(2);
if (!isChrome) {
expect(entries[0].name).toBe(srcDirNestedFirst);
expect(entries[1].name).toBe(srcDirNestedSecond);
// Directory read order is undefined on some platforms, therefore we cannot assume order
// So we will start with an expected list and iterate over the entries and test to see if they
// are in our expectation list. When found we will remove them. At the end, our expectation list
// should be empty.
const expected = [srcDirNestedFirst, srcDirNestedSecond];
for (let i = 0; i < entries.length; i++) {
const index = expected.indexOf(entries[i].name);
expect(index).toBeGreaterThan(-1);
expected.splice(index, 1);
}

expect(expected.length).toBe(0);
}
deleteEntry(dstDir, done);
}, failed.bind(null, done, 'Error getting entries from: ' + transferredDirectory));
Expand Down

0 comments on commit 1a4e3d9

Please sign in to comment.