Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the version to be Brave-only (without the Chromium major). #1240

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 25, 2024

Prevent situations where the version filter is set to a Brave version, such as: min_version: '1.72.51'.

@goodov goodov force-pushed the forbid-brave-version-without-cr-major branch from 34ab7b5 to a7c2fc5 Compare October 25, 2024 07:12
@goodov goodov changed the title Forbid the version to be Brave-only (without the Chromium major). Prevent the version to be Brave-only (without the Chromium major). Oct 25, 2024
@goodov goodov force-pushed the forbid-brave-version-without-cr-major branch from a7c2fc5 to 993374c Compare October 25, 2024 07:20
@goodov goodov marked this pull request as ready for review October 25, 2024 07:21
@goodov goodov requested a review from a team as a code owner October 25, 2024 07:21
@goodov goodov added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 885cb07 Oct 25, 2024
6 checks passed
@goodov goodov deleted the forbid-brave-version-without-cr-major branch October 25, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants