-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compare_python_gen helper. #1236
Conversation
97ce157
to
7bd0c1a
Compare
@@ -13,17 +13,19 @@ export default function createCommand() { | |||
.description('Compare two seed.bin') | |||
.argument('<seed1_file>', 'seed1 file') | |||
.argument('<seed2_file>', 'seed2 file') | |||
.argument('<seed1_serialnumber>', 'seed1 serialnumber file') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make these params optional? Otherwise it's a command not for humans, but for tests: normally just have two binary files to compare.
Maybe it makes sense to add show_serial
command instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the serialnumber files optional.
Add a helper command to run both python and TS generators to compare their outputs.
Tested on staging CI runs https://ci.brave.com/job/brave-browser-variations-publish-staging/1997/