Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare_python_gen helper. #1236

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add compare_python_gen helper. #1236

merged 3 commits into from
Oct 24, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 23, 2024

Add a helper command to run both python and TS generators to compare their outputs.

Tested on staging CI runs https://ci.brave.com/job/brave-browser-variations-publish-staging/1997/

Base automatically changed from default-params to main October 23, 2024 13:32
@goodov goodov changed the title Add compare_python_gen command helper. Add compare_python_gen helper. Oct 23, 2024
@goodov goodov marked this pull request as ready for review October 23, 2024 13:35
@goodov goodov requested a review from a team as a code owner October 23, 2024 13:35
@goodov goodov requested a review from atuchin-m October 23, 2024 13:37
@@ -13,17 +13,19 @@ export default function createCommand() {
.description('Compare two seed.bin')
.argument('<seed1_file>', 'seed1 file')
.argument('<seed2_file>', 'seed2 file')
.argument('<seed1_serialnumber>', 'seed1 serialnumber file')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make these params optional? Otherwise it's a command not for humans, but for tests: normally just have two binary files to compare.

Maybe it makes sense to add show_serial command instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the serialnumber files optional.

@goodov goodov added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 95d72c3 Oct 24, 2024
6 checks passed
@goodov goodov deleted the compare_python_gen branch October 24, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants