Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop STAGING support for griffin.brave.com #1231

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Drop STAGING support for griffin.brave.com #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cbad2a
Drop STAGING support
atuchin-m Oct 23, 2024
c9421ea
update URL for brave studies
atuchin-m Oct 23, 2024
441d8e8
Fix format
atuchin-m Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/core/base_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

export enum SeedType {
MAIN, // main Brave seed (brave-variations@main)
STAGING, // staging Brave seed (brave-variations@staging)
UPSTREAM, // Chrome seed (Finch)
}

Expand Down
12 changes: 5 additions & 7 deletions src/core/url_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import { SeedType } from './base_types';

export const variationsMainUrl = 'https://variations.brave.com/seed';
export const variationsStagingUrl = 'https://variations.bravesoftware.com/seed';
export const variationsUpstreamUrl =
'https://griffin.brave.com/finch-data-private/seed.bin';

Expand Down Expand Up @@ -47,14 +46,13 @@ export function getStudyRawConfigUrl(
study: string,
seedType: SeedType,
): string {
const BRAVE_VARIATIONS_REPO_PATTERN = '^github\\.com/brave/brave-variations$';
if (seedType === SeedType.UPSTREAM)
return `${getGitHubStorageUrl()}/blob/main/study/all-by-name/${study}`;
const branch = seedType === SeedType.MAIN ? 'main' : 'staging';
return makeSourceGraphUrl(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like https://sourcegraph.com stopped indexing brave-variations, so I've switched to github.
Also, the new URL adds studies/*.json5 to the file pattern.

`"name": "${study}"`,
`${BRAVE_VARIATIONS_REPO_PATTERN}@${branch}`,
'seed/seed.json',
return (
'https://github.com/search?type=code' +
'&q=repo%3Abrave%2Fbrave-variations' +
'+path%3A%2F%5Eseed%5C%2Fseed.json%7C%5Estudies%5C%2F*.json5%2F+' +
`"%5C"name%5C"%3A+%5C"${encodeURIComponent(study)}%5C""`
);
}

Expand Down
4 changes: 0 additions & 4 deletions src/web/app/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,6 @@ export function App() {
type={SeedType.MAIN}
searchParamManager={searchParamManager}
/>
<NavItem
type={SeedType.STAGING}
searchParamManager={searchParamManager}
/>
{hasUpstream && (
<NavItem
type={SeedType.UPSTREAM}
Expand Down
3 changes: 0 additions & 3 deletions src/web/app/seed_loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ export function loadSeedDataAsync(
loadSeedFromUrl(url_utils.variationsMainUrl, SeedType.MAIN)
.then(cb.bind(cb, SeedType.MAIN))
.catch(console.error);
loadSeedFromUrl(url_utils.variationsStagingUrl, SeedType.STAGING)
.then(cb.bind(cb, SeedType.STAGING))
.catch(console.error);
loadSeedFromUrl(url_utils.variationsUpstreamUrl, SeedType.UPSTREAM)
.then(cb.bind(cb, SeedType.UPSTREAM))
.catch(() => {
Expand Down