Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BraveRoundTimeStamps RELEASE 100% #1224

Merged
merged 1 commit into from
Oct 15, 2024
Merged

BraveRoundTimeStamps RELEASE 100% #1224

merged 1 commit into from
Oct 15, 2024

Conversation

atuchin-m
Copy link
Collaborator

Resolves #1214

@atuchin-m atuchin-m self-assigned this Oct 14, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner October 14, 2024 12:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1224.
    Android: Set the command line to --variations-pr=1224 in debug menu, restart the browser.
    iOS: Set Variations PR to 1224 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1224@3e23ace776823fa9224c9c8a7f5ebbe09171485b
Uploaded Mon, 14 Oct 2024 12:59:52 GMT
PR commit 9a384bb
Base commit 672717d
Merge commit 3e23ace
Serial number c1e096f31ef18cf3c4f11c3357e6baa4

atuchin-m
atuchin-m commented Oct 14, 2024
View reviewed changes
seed/seed.json
"RELEASE"
],
"min_version": "125.*",
"max_version": "130.1.72.75",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature was disabled here: brave/brave-core#25877 (comment)

kjozwiak
kjozwiak approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 024f17f Oct 15, 2024
7 checks passed
@kjozwiak kjozwiak deleted the BraveRoundTimeStamps-release-100% branch October 15, 2024 17:03
This was referenced Oct 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@atuchin-m atuchin-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable BraveRoundTimeStamps to fix Spotify crashes
2 participants
@atuchin-m @kjozwiak