Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump express from 4.19.2 to 4.20.0 #1211

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Bump express from 4.19.2 to 4.20.0 #1211

merged 1 commit into from
Sep 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2024

Bumps express from 4.19.2 to 4.20.0.

Release notes

Sourced from express's releases.

4.20.0

What's Changed

Important

  • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect

Other Changes

New Contributors

Full Changelog: expressjs/express@4.19.1...4.20.0

Changelog

Sourced from express's changelog.

4.20.0 / 2024-09-10

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump express from 4.19.2 to 4.20.0
3933d5f 
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 11, 2024 05:24
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

[puLL-Merge] - expressjs/[email protected]

Description

This pull request updates the CI/CD pipelines and multiple documentation files. The primary motivation for these changes seems to be the modernization and consolidation of workflows, security improvements, as well as general housekeeping of the documentation and test suites.

Changes

Changes

  1. .github/workflows/ci.yml

    • Split the existing test job into separate lint and test jobs.
    • Updated the node versions used for testing.
    • Introduced new organization (4.x, 5.x, develop branches) for triggering workflows.

  2. Add new workflows:

    • .github/workflows/codeql.yml: Adds a workflow for CodeQL analysis.
    • .github/workflows/iojs.yml: Adds a workflow specifically for testing against io.js versions 1.x, 2.x, and 3.x.

  3. .gitignore

    • Adds npm-shrinkwrap.json to the ignored files.

  4. .npmrc

    • New file added to disable package-lock (package-lock=false).

  5. Documentation Updates:

    • Code-Of-Conduct.md: Corrected a broken link reference.
    • Contributing.md: Updated the process for becoming a triager and broadened the context of existing projects and captains.
    • History.md: Added release notes for versions 4.20.0 and 4.19.2.
    • Readme.md: Expanded sections to include Table of Contents, TC members, and Triagers list.
    • Release-Process.md: Added guidelines for pre-release versions.
    • Security.md: Added details about pre-release versions and provided a reference to the security threat model.
    • Triager-Guide.md: Introduced guidelines for moving discussions and questions to GitHub Discussions.

  6. appveyor.yml

    • Added Node.js version 22.0 to the test matrix.

  7. Source Code

    • lib/response.js:
      • Refactored to remove unused urlParse and added deprecations for certain cookie options.
      • Simplified res.location and res.redirect logic.
    • package.json:
      • Updated package dependencies and bumped version to 4.20.0.
      • Adjusted test scripts to exclude certain directories from coverage.

  8. Test Suite:

    • Multiple updates across test files to adjust for changes in logic and new test cases.
      • test/app.router.js, test/express.static.js, test/express.urlencoded.js: Added new test cases and necessary utilities.
      • test/res.clearCookie.js: New test cases for the updated clearCookie method.
      • test/res.location.js: Comprehensive test cases for location header encoding and security.
      • test/res.redirect.js, test/res.send.js, test/support/utils.js: Adjusted tests and utilities to support recent changes.

Possible Issues

  • Workflow dependencies: The introduced changes in the workflows rely on certain versions of Actions, which may need to be kept up-to-date to avoid unexpected failures.
  • Backward compatibility: Removing previously used parameters or methods could cause issues for users who haven't updated their implementations accordingly.
  • Test Coverage and Maintenance: Extensive test cases added might increase the maintenance burden, especially ensuring they are always compatible with the newest changes in Node.js.

Security Hotspots

  1. Location and Redirect Encoding:

    • lib/response.js: Ensure the encoding changes don’t introduce new vulnerabilities or bypass any existing security measures.
    • test/res.location.js, test/res.redirect.js: Added tests for URL encoding to avoid vulnerabilities such as XSS.

  2. GitHub Actions:

    • Consolidation of dependencies: Dependencies and introduced actions in the workflows should be monitored for any vulnerabilities.

Overall, the PR is a comprehensive housecleaning and modernization effort for the Express repository, but it does come with the need for vigilant monitoring and maintenance of introduced workflows and dependency changes.

@atuchin-m atuchin-m added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 91b8a9d Sep 11, 2024
6 checks passed
@atuchin-m atuchin-m deleted the dependabot/npm_and_yarn/express-4.20.0 branch September 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atuchin-m atuchin-m atuchin-m approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atuchin-m