-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled DefaultPassthroughCommandDecoder flag on Android to follow upstream #1154
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
|
Example |
Example |
Example |
---|---|---|
BETA
verification(s):
Verification PASSED on Pixel 6 Pro
running Android 15
using the following build(s):
Brave | 1.69.132 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
--- | ---
Revision | 8b2ea0be418a7e957a25870ec61d676029b756c3
OS | Android 15; Build/AP31.240617.010; 35; REL
Using the STR/Cases outlined via #1154 (comment), went through the following and ensured that Passthrough Command Decoder
was being disabled.
- installed/launched
1.69.132 Chromium: 127.0.6533.88
and ensured thatPassthrough Command Decoder
was set astrue
- added
--variations-pr=1154
into theCommand Line String
via the QA debug menu - restarted
Brave
and ensured thatpull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e
viabrave://version
- checked
brave://gpu
and ensured thatPassthrough Command Decoder
was set asfalse
- ensured that videos/media via TY played without any issues
Example |
Example |
Example |
---|---|---|
Release
verification(s):
Verification PASSED on Pixel 6 Pro
running Android 15
using the following build(s):
Brave | 1.68.134 Chromium: 127.0.6533.88 (Official Build) (64-bit)
--- | ---
Revision | 71f3c9cc80f92022892bbf6a22c0450ea056ade4
OS | Android 15; Build/AP31.240617.010; 35; REL
Using the STR/Cases outlined via #1154 (comment), went through the following and ensured that Passthrough Command Decoder
was being disabled.
- installed/launched
1.68.134 Chromium: 127.0.6533.88
and ensured thatPassthrough Command Decoder
was set astrue
- added
--variations-pr=1154
into theCommand Line String
via the QA debug menu - restarted
Brave
and ensured thatpull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e
viabrave://version
- checked
brave://gpu
and ensured thatPassthrough Command Decoder
was set asfalse
- ensured that videos/media via TY played without any issues
Example |
Example |
Example |
---|---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Went through verifications without any issues.
…pstream (#1155) A production version of #1154 Co-authored-by: Kamil Jozwiak <[email protected]>
Resolves #1153
Resolves brave/brave-browser#40225
I don't think anyone has a problem device except me currently. I can confirm that I don't see the problem once I disable the flag and that's how it is in Chrome as well. There are also reports from users that disabling it fixes the issue
https://community.brave.com/t/youtube-all-videos-appear-as-a-pink-screen-since-brave-version-1-68-128/560453/1
https://www.reddit.com/r/brave_browser/comments/1eeaz1j/youtube_pink_video_issue/
It could be verified that passthrough feature is disabled from chrome://gpu. Make sure you have
Passthrough Command Decoder
set to false inDriver Information
section there after the variation applies. That flag is enabled by default, we want to disable it.