Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled DefaultPassthroughCommandDecoder flag on Android to follow upstream #1154

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Aug 2, 2024

Resolves #1153
Resolves brave/brave-browser#40225

I don't think anyone has a problem device except me currently. I can confirm that I don't see the problem once I disable the flag and that's how it is in Chrome as well. There are also reports from users that disabling it fixes the issue
https://community.brave.com/t/youtube-all-videos-appear-as-a-pink-screen-since-brave-version-1-68-128/560453/1
https://www.reddit.com/r/brave_browser/comments/1eeaz1j/youtube_pink_video_issue/
It could be verified that passthrough feature is disabled from chrome://gpu. Make sure you have Passthrough Command Decoder set to false in Driver Information section there after the variation applies. That flag is enabled by default, we want to disable it.
Screenshot_20240802-091924

@SergeyZhukovsky SergeyZhukovsky self-assigned this Aug 2, 2024
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner August 2, 2024 13:43
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1154.
    Android: Set the command line to --variations-pr=1154 in debug menu, restart the browser.
    iOS: Set Variations PR to 1154 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e
  • Uploaded: 2024-08-02T13:45:24.400Z
  • Serial Number: a92f3ecd25978d297d09a7dcc9915f37

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2024

Nightly verification(s):

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.70.32 Chromium: 127.0.6533.73 (Official Build) canary (64-bit)
--- | ---
Revision | 71e63cf907b8e6d1d64b9c6465c8679e06ff93ce
OS | Android 15; Build/AP31.240617.010; 35; REL

Using the STR/Cases outlined via #1154 (comment), went through the following and ensured that Passthrough Command Decoder was being disabled.

  • installed/launched 1.70.32 Chromium: 127.0.6533.73 and ensured that Passthrough Command Decoder was set as true
  • added --variations-pr=1154 into the Command Line String via the QA debug menu
  • restarted Brave and ensured that pull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e via brave://version
  • checked brave://gpu and ensured that Passthrough Command Decoder was set as false
  • ensured that videos/media via TY played without any issues
Example Example Example
Screenshot_20240802-123030 Screenshot_20240802-122711 Screenshot_20240802-122913

BETA verification(s):

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.69.132 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
--- | ---
Revision | 8b2ea0be418a7e957a25870ec61d676029b756c3
OS | Android 15; Build/AP31.240617.010; 35; REL

Using the STR/Cases outlined via #1154 (comment), went through the following and ensured that Passthrough Command Decoder was being disabled.

  • installed/launched 1.69.132 Chromium: 127.0.6533.88 and ensured that Passthrough Command Decoder was set as true
  • added --variations-pr=1154 into the Command Line String via the QA debug menu
  • restarted Brave and ensured that pull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e via brave://version
  • checked brave://gpu and ensured that Passthrough Command Decoder was set as false
  • ensured that videos/media via TY played without any issues
Example Example Example
Screenshot_20240802-124339 Screenshot_20240802-124037 Screenshot_20240802-124205

Release verification(s):

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.68.134 Chromium: 127.0.6533.88 (Official Build) (64-bit)
--- | ---
Revision | 71f3c9cc80f92022892bbf6a22c0450ea056ade4
OS | Android 15; Build/AP31.240617.010; 35; REL

Using the STR/Cases outlined via #1154 (comment), went through the following and ensured that Passthrough Command Decoder was being disabled.

  • installed/launched 1.68.134 Chromium: 127.0.6533.88 and ensured that Passthrough Command Decoder was set as true
  • added --variations-pr=1154 into the Command Line String via the QA debug menu
  • restarted Brave and ensured that pull/1154@02e72d248e8d64b46a71638607e443c17cdb9c8e via brave://version
  • checked brave://gpu and ensured that Passthrough Command Decoder was set as false
  • ensured that videos/media via TY played without any issues
Example Example Example
Screenshot_20240802-130049 Screenshot_20240802-125802 Screenshot_20240802-125822

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Went through verifications without any issues.

@kjozwiak kjozwiak merged commit 68d1f56 into main Aug 2, 2024
7 checks passed
@kjozwiak kjozwiak deleted the android_disable_passthrough_com_dec branch August 2, 2024 17:04
kjozwiak added a commit that referenced this pull request Aug 2, 2024
…pstream (#1155)

A production version of
#1154

Co-authored-by: Kamil Jozwiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable DefaultPassthroughCommandDecoder on Android Pink screen on YT video
2 participants