Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BraveSearchPromotionDDGBannerStudy #1076

Closed
wants to merge 1 commit into from
Closed

Conversation

simonhong
Copy link
Member

Added to another search promotion targets for DDG users
We targets 100% users and each type has 25%.

@simonhong simonhong self-assigned this May 31, 2024
@simonhong simonhong requested a review from a team as a code owner May 31, 2024 02:32
@simonhong
Copy link
Member Author

@rebron this doesn't have min version as I'm not sure it's started from 1.68.x or not.
If we want to start this from 1.67.x, I'll set 1.67 as min version. Otherwise, it could be 1.68.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to close the above as discussed with @rebron via the desktop call. It's been opened for ~2 months without any movement. I believe the Search Promotion feature is also being changed/re-worked. The DDG images/campaign is also being re-worked/needs new assets.

@kjozwiak kjozwiak closed this Aug 9, 2024
@kjozwiak kjozwiak deleted the add_ddg_banner_study branch August 9, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants