Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39 (1.73.x). #26423

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39 (1.73.x). #26423

merged 5 commits into from
Nov 7, 2024

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 6, 2024 •
edited
Loading

Resolves brave/brave-browser#42129

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

brave-builds and others added 4 commits November 6, 2024 23:23
@brave-builds
Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39
2a0c3ba
@brave-builds
Update pins list timestamp
55f9740
@brave-builds
Updated strings for Chromium 131.0.6778.39
767be56
@emerick @mkarolin
[cr132] IsURLAllowedInIncognito dropped BrowserContext
54d6179 
After discussion, we decided to eliminate the wallet check from
IsURLAllowedInIncognito instead allowing brave_wallet::IsAllowedForContext to
perform the required check. This does mean that if the "Allow wallet URLs in
private windows" option is not enabled and a user opens a wallet URL in a
private window it will result in a load failure rather than redirect to a normal
window.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/00708f413a9c2b37699a92cfadcdd18d872ffa2a

commit 00708f413a9c2b37699a92cfadcdd18d872ffa2a
Author: Thomas Lukaszewicz <[email protected]>
Date:   Mon Oct 21 19:41:59 2024 +0000

    Eliminate unused BrowserContext* param from IsURLAllowedInIncognito()

    Removes the param from the function and cleans up client code.

    Bug: 368059979
@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Nov 6, 2024
@mkarolin mkarolin self-assigned this Nov 6, 2024
@mkarolin mkarolin requested a review from a team as a code owner November 6, 2024 23:27
@mkarolin mkarolin mentioned this pull request Nov 6, 2024
Closed
24 tasks
@kjozwiak kjozwiak added this to the 1.73.x - Release milestone Nov 7, 2024
kjozwiak
kjozwiak approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.73.x approved 👍

@kjozwiak kjozwiak merged commit d1a6765 into 1.73.x Nov 7, 2024
15 checks passed
@kjozwiak kjozwiak deleted the 131.0.6778.39_1.73.x branch November 7, 2024 05:39
@brave-builds
Copy link
Collaborator

Released in v1.73.86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@mkarolin @brave-builds @kjozwiak @emerick