-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Send page land immediately for non-successful HTTP status codes #26404
base: master
Are you sure you want to change the base?
Conversation
17b2af8
to
6ba8a78
Compare
components/brave_ads/core/internal/common/net/http/http_status_code_util.cc
Outdated
Show resolved
Hide resolved
0b712b8
to
67472a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c8d421e
to
4c6d6e1
Compare
[puLL-Merge] - brave/brave-core@26404 DescriptionThis PR makes changes to the Brave Ads component, primarily focusing on improving the handling of HTTP status codes in site visit tracking and ad serving. It also includes some refactoring and test improvements. ChangesChanges
Possible IssuesNone identified. Security HotspotsNone identified. |
Resolves brave/brave-browser#42137
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
For pages returning HTTP status codes in the 4xx and 5xx ranges, redeem a
landed
confirmation token for Rewards users immediately without a 5-second delay. For status codes in the 2xx and 3xx ranges, apply a 5-second delay before redeeming the confirmation token.