Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Moved back simplified view prompt for regular tabs (uplift to 1.73.x) #26403

Open
wants to merge 2 commits into
base: 1.73.x
Choose a base branch
from
Open

[Android] Moved back simplified view prompt for regular tabs (uplift to 1.73.x) #26403

wants to merge 2 commits into from
+40 −0

Commits on Nov 6, 2024

  1. [Android] Moved back simplified view prompt for regular tabs 

    This is regression from this chromium change:
https://chromium.googlesource.com/chromium/src/+/c20ba57087f147b22a78a0fd916fdc4b887c2946

Cleanup Reader mode contextual page action

This CL cleans up ContextualPageActionReaderMode feature. There are
some details after the cleanup which can be summarized as :
1. Reader mode message UI is now only shown in CCT and incognito.
2. Finch param reader_mode_session_rate_limiting is set to
false. Hence it was removed in this CL.
3. CPA alternative color is also unused, but there are some feature
teams such as shopping who are interested in a similar experiment in
future. Hence it was kept as is.
4. There is also some code related to muting certain sites if the
user didn't take action. These are still needed for the message UI
that is shown for CCT and incognito.

Bug: 356237338
    @samartnik
    samartnik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3088c1b View commit details
    Browse the repository at this point in the history

  2. [Android] Fix for presubmit error

    @samartnik
    samartnik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8b512d7 View commit details
    Browse the repository at this point in the history