[Android] Moved back simplified view prompt for regular tabs (uplift to 1.72.x) #26388
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is regression from this chromium change: https://chromium.googlesource.com/chromium/src/+/c20ba57087f147b22a78a0fd916fdc4b887c2946 Cleanup Reader mode contextual page action This CL cleans up ContextualPageActionReaderMode feature. There are some details after the cleanup which can be summarized as : 1. Reader mode message UI is now only shown in CCT and incognito. 2. Finch param reader_mode_session_rate_limiting is set to false. Hence it was removed in this CL. 3. CPA alternative color is also unused, but there are some feature teams such as shopping who are interested in a similar experiment in future. Hence it was kept as is. 4. There is also some code related to muting certain sites if the user didn't take action. These are still needed for the message UI that is shown for CCT and incognito. Bug: 356237338
|
Closing in favour of #26403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #26375
Resolves brave/brave-browser#42087
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: