Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA]: Create PWAs, not shortcuts #26349

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[PWA]: Create PWAs, not shortcuts #26349

merged 2 commits into from
Nov 5, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#42057

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner November 4, 2024 01:30
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Nov 4, 2024
@fallaciousreasoning fallaciousreasoning merged commit dbcaadf into master Nov 5, 2024
17 checks passed
@fallaciousreasoning fallaciousreasoning deleted the pwa-shortcuts branch November 5, 2024 19:21
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Nov 5, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.77

@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PWA]: Revert to the old Create shortcut behavior with the option to open the site as a window
4 participants