Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet) Implement Meld Buy Flow in the FE (uplift to 1.72.x) #26305

Closed
wants to merge 1 commit into from
Closed

feat(wallet) Implement Meld Buy Flow in the FE (uplift to 1.72.x) #26305

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 30, 2024 •
edited by kjozwiak
Loading

Uplift of #25088
Resolved brave/brave-browser#38985

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 30, 2024 20:52
@brave-builds brave-builds requested a review from a team October 30, 2024 20:52
@brave-builds brave-builds added this to the 1.72.x - Beta milestone Oct 30, 2024
@brave-builds brave-builds self-assigned this Oct 30, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Oct 30, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 31, 2024
kjozwiak
kjozwiak reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as per the discussion with @srirambv @Douglashdaniel and @jamesmudgett. @srirambv found several issues while running through the above via 1.73.x. We'll need to get all the issues addressed and then uplift once again once everything is completed.

@kjozwiak kjozwiak closed this Nov 6, 2024
@kjozwiak kjozwiak deleted the pr25088_feat/meld-integration_1.72.x branch November 6, 2024 01:47
@kjozwiak kjozwiak removed this from the 1.72.x - Beta milestone Nov 6, 2024
@kjozwiak kjozwiak removed the request for review from a team November 6, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@brave-builds brave-builds

Labels
chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak