Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Changes for unit tests #25556

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Sep 13, 2024

Now we will have separate suite for java unit tests to run. In addition, tests will be run on x64 emulators like they started doing in the upstream.

Resolves brave/brave-browser#40885

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added this to the 1.72.x - Nightly milestone Sep 13, 2024
@samartnik samartnik self-assigned this Sep 13, 2024
@samartnik samartnik requested a review from a team as a code owner September 13, 2024 17:52
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++. we need to coordinate changes with dev ops team

@samartnik samartnik modified the milestones: 1.72.x - Beta, 1.73.x - Nightly Oct 18, 2024
Now we will have separate suite for java unit tests to run. In addition, tests will be run on x64 emulators like they started doing in the upstream.
Changing from `google_api` to `google_atd` to avoid issues with starting emulator on our build instances.
@samartnik samartnik merged commit 2f07e44 into master Nov 6, 2024
21 checks passed
@samartnik samartnik deleted the android_unit_tests_changes branch November 6, 2024 12:27
brave-builds added a commit that referenced this pull request Nov 6, 2024
brave-builds added a commit that referenced this pull request Nov 6, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.79

@samartnik samartnik added the QA/No label Nov 6, 2024
@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
kjozwiak pushed a commit that referenced this pull request Nov 6, 2024
kjozwiak pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Make brave_public_test_apk a separate test suite and run tests on x64 emulator
5 participants