Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ran chromium_rebase_l10n after merging new l10n files. #21669

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#35470

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jan 22, 2024
@mkarolin mkarolin self-assigned this Jan 22, 2024
@mkarolin mkarolin requested a review from a team as a code owner January 22, 2024 03:37
@kjozwiak kjozwiak added this to the 1.62.x - Release milestone Jan 22, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit 730b41c into 1.62.x Jan 22, 2024
15 checks passed
@kjozwiak kjozwiak deleted the maxk-fix-chromium-rebase-l10-results-1.62.x branch January 22, 2024 05:11
kjozwiak pushed a commit that referenced this pull request Jan 22, 2024
* Updated l10n for 1.62.x release. (#21661)

* Re-ran chromium_rebase_l10n after merging new l10n files. (#21669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants