[Uplift 1.62.x] #21408 AI Chat retrieves page text whenever a new human message is submitted #21612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petemill
commented
Jan 18, 2024
•
petemill
commented
- Uplifts AI Chat retrieves page text whenever a new human message is submitted #21408
- Resolves AI Chat: Handle page content changing during conversation brave-browser#34706
- Resolves AI Chat: Fix same-document navigations brave-browser#34946
github-actions
bot
added
the
CI/storybook-url
petemill
force-pushed
the
ai-chat-page-text-updates-1.62.x
branch
from
9b11a33
to
d6987bc
Compare
|
A Storybook has been deployed to preview UI for the latest push |
…#21408) * AI Chat retrieves page text whenever a new human message is submitted On a page-connected conversation, every message becomes pending until page content is (re-)fetched. Also fixes bug for same-document navigations where class variables were being hidden by subclass variables left over from the iOS refactor. * Generating page content becomes inline operation with callback and provides content caching * Only fetch page content once at a time, other callers wait for current operation to complete * Update iOS subclasses to be compatible with ConversationDriver class changes * AI Chat: fix location bar submitted entry not submitting if request in progress
petemill
force-pushed
the
ai-chat-page-text-updates-1.62.x
branch
from
c001159
to
e45263a
Compare
|
A Storybook has been deployed to preview UI for the latest push |
kjozwiak
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Uplift into 1.62.x approved 👍 QA has verified the above PR(s) on Nightly via 1.64.x as per #21408 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.