Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced copy text from image feature on macOS #16508

Merged
merged 10 commits into from
Jan 13, 2023
Merged

Introduced copy text from image feature on macOS #16508

merged 10 commits into from
Jan 13, 2023

Commits on Jan 13, 2023

  1. Introduced copy text from image feature on macOS 

    fix brave/brave-browser#27513

"Copy Text From Image" entry is added to render view's context menu.
It gets bitmap data from renderer via LocalFrame::GetImage() mojom interface,
and then passed it to TextRecognitionDialog to extract and show text from that
image.
    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    9cf444c View commit details
    Browse the repository at this point in the history

  2. Updated using std::copy and stringstream

    @bsclifton @simonhong
    bsclifton authored and simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    f3cccf6 View commit details
    Browse the repository at this point in the history

  3. Used base::JoinString() to make strings into one string

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    9e7c139 View commit details
    Browse the repository at this point in the history

  4. Tracks text recognition dialog is already active or not for each tab 

    If renderer is busy or on slow machine, copy image could take some time.
In that situation, user could ask copy text menu multiple times. And then,
browser would get multiple copied image from renderer. When it happens,
use same dialog and show lastly recognized text in dialog instead of
creating multiple dialogs.
    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6d5d605 View commit details
    Browse the repository at this point in the history

  5. Use text_recognition namespace for text_recognition components

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    7cdd8b1 View commit details
    Browse the repository at this point in the history

  6. Moved compiler:enable_arc target into macOS only part

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b4b3dd8 View commit details
    Browse the repository at this point in the history

  7. Make TextRecognitionDialogTracker track widget status more accurately

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    a055c91 View commit details
    Browse the repository at this point in the history

  8. Make text_recognition/browser target as shared lib

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    58f54ea View commit details
    Browse the repository at this point in the history

  9. Added TextRecognitionBrowserTest browser test 

    This test extract "brave" text from test image.
    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    8e18d4a View commit details
    Browse the repository at this point in the history

  10. Reordering properties in text_recognition/browser target

    @simonhong
    simonhong committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6855228 View commit details
    Browse the repository at this point in the history