Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39 #42129

Closed
mkarolin opened this issue Nov 6, 2024 · 3 comments · May be fixed by brave/brave-core#26426
Closed

Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39 #42129

mkarolin opened this issue Nov 6, 2024 · 3 comments · May be fixed by brave/brave-core#26426
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-macOS-arm64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.73.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Nov 6, 2024 •
edited
Loading

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/131.0.6778.24..131.0.6778.39?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@mkarolin mkarolin added Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/Test-Plan-Specified QA/Yes release-notes/include labels Nov 6, 2024
This was referenced Nov 6, 2024
Closed
Closed
Closed
@mkarolin mkarolin changed the title Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.33 Upgrade from Chromium 131.0.6778.24 to Chromium 131.0.6778.39 Nov 6, 2024
@mkarolin mkarolin assigned mkarolin and unassigned emerick Nov 6, 2024
This was referenced Nov 6, 2024
Merged
Merged
Open
@kjozwiak kjozwiak closed this as completed Nov 7, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2024

The above requires 1.73.86 or higher for 1.73.x verification 👍

@kjozwiak kjozwiak mentioned this issue Nov 7, 2024
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2024

Quick overview of the work remaining re: affected areas due to C131 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #41130 (comment):

Platforms that still need to check/verify the affected areas due to C131 changes as per #41130 (comment):

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.73.86 Chromium: 131.0.6778.39 (Official Build) (arm64)
-- | --
Revision | 52163bcf4e40f27ddb76ffa79c90a8833084a9bd
OS | macOS Version 12.5 (Build 21G72)
Settings UI icons look correctly_PASSED
  • Verified the settings UI as part of settings comparison section testing on Windows
Side panel works correctly (opening/closing various panels)_PASSED
  • Ensured that Side panel buttons works as expected
Screen.Recording.2024-11-07.at.12.27.09.PM.mov
Tab search bubble looks correctly_PASSED
  • Confirmed that all the opened/closed tabs are opened via Tab search panel
  • Confirmed that user can see recently closed tabs via Tab search panel
  • Confirmed that user can search specific site via Tab search panel
  • Confirmed that user can close the specific tab via Tab search panel
Screen.Recording.2024-11-07.at.12.12.47.PM.mov
Settings search engines look correctly_PASSED
Case 1: New user from Brave Search default SE target country (India)_PASSED
  1. Clean profile 1.73.x
  2. Check Brave is the default SE via brave://settings/search for both Normal and Private windows
  3. Check that Change button is shown next to default SE for Normal window search settings
  4. Click on Change button and ensured that list of SE's displayed in the dropdown
  5. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
  6. Check search suggestions option is enabled by default in brave://settings/search
  7. Confirmed brave search suggestions are shown when typing into the omnibox
Case 2: Existing user from Brave Search default SE target country (India)_default search settings not modified prior upgrade_PASSED
  1. Clean profile 1.71.x
  2. Check Brave is the default SE via brave://settings/search
  3. Check search suggestions option is enabled by default in brave://settings/search
  4. Upgrade the profile to 1.73.x
  5. Check that Change button is shown next to default SE for Normal window search settings
  6. Click on Change button and ensured that list of SE's displayed in the dropdown
  7. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
  8. Confirm brave search suggestions are shown when typing into the omnibox
Case 3: Existing user from Brave Search default SE target country (India)_default search settings modified prior upgrade_PASSED
  1. Clean profile 1.71.x
  2. Check Brave is the default SE via brave://settings/search
  3. Check search suggestions option is enabled by default in brave://settings/search
  4. Change the default SE to Bing or any SE other than Brave in both Normal and PT
  5. Upgrade the profile to 1.73.x
  6. Check that Bing is the default SE in both Normal and PT windows and Change button is shown next to default SE for Normal window
  7. Click on Change button and ensured that list of SE's displayed in the dropdown
  8. Confirmed that Brave is first SE in the dropdown
  9. Confirm Bing search suggestions are shown when typing into the omnibox
  10. Change the Search engine to Google and click on Set as default
  11. Confirmed default SE is set to Google in Normal windows
  12. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner
Case 4: New user from outside brave search target country (Cuba)_PASSED
  1. Clean profile 1.73.x
  2. Open brave://settings/search and ensured that Google is the default SE
  3. Confirmed that Change button is shown next to default SE for Normal window SE settings
  4. Click on Change button and ensured that list of SE's displayed in the dropdown
  5. Confirmed that Google SE radio button is selected
  6. Confirmed that Brave is first SE in the dropdown
  7. Confirmed that Show search suggestion settings is disabled as expected
  8. Confirm Google search suggestions are shown when typing into the omnibox
Case 5: New user from outside brave search target country (Cuba)_default search settings not modified prior upgrade_PASSED
  1. Clean profile 1.71.x
  2. Open brave://settings/search and ensured that Google is the default SE
  3. Upgrade the profile to 1.73.x
  4. Open brave://settings/search and ensured that Google is the default SE
  5. Confirmed that Change button is shown next to default SE for Normal window SE settings
  6. Click on Change button and ensured that list of SE's displayed in the dropdown
  7. Confirmed that Google SE radio button is selected
  8. Confirmed that Brave is first SE in the dropdown
  9. Confirmed that Show search suggestion settings is disabled as expected
  10. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner
Case 6: Existing user from outside brave search target country (Cuba)_default search settings modified prior upgrade_PASSED
  1. Clean profile 1.71.x
  2. Open brave://settings/search and ensured that Google is the default SE
  3. Change the default SE to any SE other than Google (I have changed SE to StartPage)
  4. Upgrade the profile to 1.73.x
  5. Open brave://settings/search and ensured that StartPage is the default SE
  6. Confirmed that Change button is shown next to default SE for Normal window SE settings
  7. Click on Change button and ensured that list of SE's displayed in the dropdown
  8. Confirmed that StartPage SE radio button is selected
  9. Confirmed that Brave is first SE in the dropdown
  10. Confirmed that Show search suggestion settings is disabled as expected
  11. Confirm StartPage search suggestions are shown when typing into the omnibox along with Brave search promo banner
Widevine popup is shown, installs correctly_PASSED
  • Confirmed that Install and run Widevine notification is shown when user logged into Netflix.com
  • Confirmed that relaunch notification is shown upon clicking on Allow option via Install and run Widevine notification
  • Confirmed that Widevine settings is turned ON once user click on Allow option and relaunch the browser
  • Confirmed that user can stream videos via Netflix.com after installing Widevine extension
  • Confirmed that Install and run Widevine notification is shown every time when user turned OFF Widevine settings manually
New Tab looks correctly for normal, private, tor profiles_PASSED
  • Confirmed that click on New Tab + icon works as expected in Normal/PT/Tor tab windows
  • Confirmed that Active tab color is shown as expected in Normal/PT/Tor tab windows
  • Confirmed that Inactive tab color is shown as expected in Normal/PT/Tor tab windows

Light theme:

Normal window new tab Private new tab Tor window new Tab
Image Image Image

Dark theme:

Normal window new tab Private new tab Tor window new Tab
Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-macOS-arm64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release
5 participants
@kjozwiak @emerick @GeetaSarvadnya @mkarolin @brave-builds