Skip to content

Commit

Permalink
[Cr131 follow up][Linux] Fixes dragging window by toolbar. (uplift to…
Browse files Browse the repository at this point in the history
… 1.72.x) (#26368)

Uplift of #26366 (squashed) to beta
  • Loading branch information
brave-builds authored Nov 5, 2024
1 parent 006f304 commit f144f47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,7 @@ using BraveNonClientHitTestHelperBrowserTest = InProcessBrowserTest;

// TODO(sko) It might be good to have resizable area tests. But testing it
// is pretty flaky depending on platforms.
// The test is failing on Linux CI in Chromium 131, but passes locally:
// https://github.com/brave/brave-browser/issues/41674
#if BUILDFLAG(IS_LINUX)
#define MAYBE_Toolbar DISABLED_Toolbar
#else
#define MAYBE_Toolbar Toolbar
#endif // BUILDFLAG(IS_LINUX)
IN_PROC_BROWSER_TEST_F(BraveNonClientHitTestHelperBrowserTest, MAYBE_Toolbar) {
IN_PROC_BROWSER_TEST_F(BraveNonClientHitTestHelperBrowserTest, Toolbar) {
auto* browser_view = static_cast<BrowserView*>(browser()->window());
auto* toolbar = browser_view->toolbar();
// Upstream has two more children |background_view_left_| and
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
#include "chrome/browser/ui/views/frame/browser_frame_view_linux.h"
#include "brave/browser/ui/views/frame/brave_opaque_browser_frame_view.h"

#define OpaqueBrowserFrameView(frame, browser_view, layout) \
BraveOpaqueBrowserFrameView(frame, browser_view, layout)

#define OpaqueBrowserFrameView BraveOpaqueBrowserFrameView
#include "src/chrome/browser/ui/views/frame/browser_frame_view_linux.cc"

#undef OpaqueBrowserFrameView

0 comments on commit f144f47

Please sign in to comment.