Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.js added to create an package on atmospherejs #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andredeloliveira
Copy link

Hello!
I am a Meteor.js developer and I found your solution very useful for my application. Really, it is a greate solution. I am opening this pull request to add the package.js file into the portal, so it can be reviewed and updated in the Atmosphere.js portal.

Thank you again for creating this!

Cheers,
Andre.

@andredeloliveira andredeloliveira changed the title package.js added to create an package on atmosphere.js package.js added to create an package on atmospherejs Feb 14, 2016
@brandly
Copy link
Owner

brandly commented Feb 16, 2016

hey andre! i didn't know about Atmosphere.js.

looking at the package.js, why are dependencies, like lodash, listed? it looks like they're also listed on atmospherejs.com.

it seems like we should remove those

@andredeloliveira
Copy link
Author

Hey!
Well, I was following bower.json dependencies. They are listed on atmospherejs.com because they are in thepackage.js file as well. If lodash is not a a dependency we can remove it, otherwise we have to keep it. :)

@brandly
Copy link
Owner

brandly commented Feb 16, 2016

oh i see! the bower.json devDependencies aren't needed to use this directive in your project. they are needed to run tests against this project, so they're for development, not the end user.

i think they can be taken out for Atmosphere. thanks!

@andredeloliveira
Copy link
Author

Oh, I understand now.
Well, we can remove lodash then as the others are dependencies to actually use the directive :).

Thanksk for letting me know about it 😄

@brandly
Copy link
Owner

brandly commented Feb 16, 2016

we should be fine without angular-mocks as well

@andredeloliveira
Copy link
Author

Cool! We can do that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants