Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libcec-daemon for libcec-4.0.5 #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update libcec-daemon for libcec-4.0.5 #32

wants to merge 4 commits into from

Conversation

matthewbauer
Copy link

No description provided.

@matthewbauer matthewbauer mentioned this pull request Sep 6, 2020
Closed
bramp
bramp reviewed Sep 6, 2020
View reviewed changes
Copy link
Owner

@bramp bramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a comment somewhere as to which version of libcec this now builds for? and update the Makefile.am to have "libcec >= 4.0"

src/libcec.cpp Show resolved Hide resolved
Makefile.am
@@ -1,6 +1,8 @@
AUTOMAKE_OPTIONS = subdir-objects
ACLOCAL_AMFLAGS = -I m4

AM_LDFLAGS = "-pthread"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does libcec now require pthreads?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is if you link against libraspberrypi. Otherwise, it might not be.

@satmandu
Copy link

Thanks for this. It allows building against the current libcec...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramp bramp bramp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewbauer @satmandu @bramp