Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine recordings #717

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Edouard2laire
Copy link
Contributor

@Edouard2laire Edouard2laire commented Jul 6, 2024

Hello,

This is the continuation of #660 in the attempt to enhance multimodal data analysis in Brainstorn.

Since, having multiple raw viewer recording with multiple sampling rate is not accessible (#656), i made this process to combine recording and resampling them to the highest frequency.

This allows to make such visualization directly from Brainstorm:

image

This assume that the signals were synchronized

Todo:

  • User-specified folder name
  • Copy channel flag
  • Copy video if present (not necessary actually. can be loaded from the other folder)

Question:

  • Better way to merge channels?
    I am not sure if the way I am doing is ok; especially if I need to merge headpoints / fiducials ...

  • How to deal with events ?
    Same thing, I am only copying events from the first file ? Should we merge them adding a sufixe to the name to identify the file ?

@Edouard2laire Edouard2laire marked this pull request as ready for review September 5, 2024 18:20
@Edouard2laire
Copy link
Contributor Author

hello @rcassani

This PR is ready for review.

The only things I am not sure are: the events ( how to merge event from multiple file - esp after synchronization there will be a lot of duplicate if we just concatenate the events), and the channel flag.

Let me know if you have any questions.

I'll try to complete all the PR I have as draft soon :)

@Edouard2laire
Copy link
Contributor Author

ok i completed my todo list.

@rcassani, let me know when you would have time to review this. Let me know if you need an example dataset

@rcassani rcassani closed this Oct 30, 2024
@rcassani rcassani reopened this Oct 30, 2024
@rcassani
Copy link
Member

@Edouard2laire, apologies for closing the PR, I was trying to close my comment —duh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants