improve detection debug logs #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
approved these changes
Feb 7, 2024
willGraham01
added a commit
that referenced
this pull request
Feb 7, 2024
This reverts commit 448170b.
willGraham01
added a commit
that referenced
this pull request
Feb 7, 2024
….0` (#369) * Add skimage missing dependency and boot broken pytest-lazy-fixture * Remove lazy-fixture dependent fixtures * Clarify problem fixture docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove fixtures and get pytest to check for cpu availability at runtime * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Actually raise the exception for not enough CPUs * try attempting garbage collector to run at end of test * Remove double dependency * improve detection debug logs (#375) * improve detection debug logs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove too wordy debug logs --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Searching for min. segfault example (#376) Reverting apparently un-neccessary changes due to conflation with a bad cache fetch. * Revert "try attempting garbage collector to run at end of test" This reverts commit 2753abb. * Revert "Actually raise the exception for not enough CPUs" This reverts commit 1545b1b. * Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks" This reverts commit bdd0d91. * Revert "Remove fixtures and get pytest to check for cpu availability at runtime" This reverts commit 125fa9d. * Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks" This reverts commit dd0e519. * Revert "Clarify problem fixture docstrings" This reverts commit 67caf82. * Add a timeout to CI for runs * ignore vscode configs in git * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump timeout to 60 mins --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Alessandro Felder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
What does this PR do?
Slightly more verbose debug logs for some parts of detection.
Might help us with memory issues in #372
References
#372
How has this PR been tested?
Visual inspection of running a simple script on the SWC cluster.
Three extra lines of debug logs never hurt anyone :)
Is this a breaking change?
Nope.
Does this PR require an update to the documentation?
Nope
Checklist: