Prep merge

[adamltyson]

Combines two very similar functions and also removes a seemingly redundant function arguement.

@sfmig I've somewhat naively updated the benchmarking code, but I may have done this wrong.

Closes #272

[adamltyson]

brainmapper updated in brainglobe/brainglobe-workflows#66

[willGraham01]

Worth flagging here that when this update and the matching one on workflows goes in, we should make new releases for both. (In particular, the workflows PR should force a minimum version of cellfinder that corresponds to the new release).

And another thing I've just noticed:

• Publishing a new release requires the brainmapper CI check to pass, but it won't without the latest update to workflows.
• Publishing a new workflows release requires CI to pass, which requires the new version of cellfinder

So theoretically we can never publish this release (need to release cellfinder to release workflows, and the converse is also true).

In the interest of resolving this, I guess we make the brainmapper CI check in this repo optional when creating a release and/or merging a PR? That way we at least have a check which'll indicate when things can potentially go wrong and need to be fixed in workflows too.

[adamltyson]

In the interest of resolving this, I guess we make the brainmapper CI check in this repo optional when creating a release and/or merging a PR? That way we at least have a check which'll indicate when things can potentially go wrong and need to be fixed in workflows too.

Yeah I think that's the way.

[willGraham01]

Yeah I think that's the way.

Have added this change to this branch.

[willGraham01]

@adamltyson do you want me to merge this, publish the release, and then try re-running the CI on brainglobe/brainglobe-workflows#66 ?

[adamltyson]

Sounds good