Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numba workflow patch #265

Merged
merged 2 commits into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions .github/workflows/test_and_deploy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: tests
name: Test (and Deploy to PyPI on tag)

on:
# Only run on pushes to main, or when version tags are pushed
Expand All @@ -22,6 +22,7 @@ concurrency:
jobs:
linting:
runs-on: ubuntu-latest
name: Check Linting
steps:
- uses: neuroinformatics-unit/actions/lint@v2

Expand Down Expand Up @@ -65,6 +66,30 @@ jobs:
python-version: ${{ matrix.python-version }}
use-xvfb: true

test_numba_disabled:
needs: [linting, manifest]
name: Run tests with numba disabled
runs-on: ubuntu-latest
env:
NUMBA_DISABLE_JIT: "1"

steps:
- name: Cache tensorflow model
uses: actions/cache@v3
with:
path: "~/.cellfinder"
key: models-${{ hashFiles('~/.cellfinder/**') }}
# Setup pyqt libraries
- name: Setup qtpy libraries
uses: tlambert03/setup-qt-libs@v1
# Setup VTK with headless display
- uses: pyvista/setup-headless-display-action@v2
# Run test suite with numba disabled
- uses: neuroinformatics-unit/actions/test@v2
with:
python-version: "3.10"
codecov-flags: "numba"

# Run brainglobe-workflows brainmapper-CLI tests to check for
# breakages
# test_brainmapper_cli:
Expand Down Expand Up @@ -102,7 +127,7 @@ jobs:

build_sdist_wheel:
name: Build source distribution and wheel
# needs: [test, test_brainmapper_cli]
# needs: [test, test_brainmapper_cli, test_numba_disabled]
needs: [test]
if: github.event_name == 'push' && github.ref_type == 'tag'
runs-on: ubuntu-latest
Expand Down
27 changes: 0 additions & 27 deletions .github/workflows/test_numba_off.yml

This file was deleted.