Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer captions / updated text&screenshots #61

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Sep 1, 2023

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

  • We've changed the title of structure view widget in brainrender-napari from "3D brain region meshes" to "3D atlas region meshes".
  • There is a bug in the captions display: Captions are on the wrong line.

What does this PR do?

  • fixes captions and updates text and screenshots with name change.

References

Closes #58
Closes #60

How has this PR been tested?

Visual inspection (I could reproduce #60 before these changes).

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • (manually) The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • [n/a] The code has been formatted with pre-commit

@alessandrofelder alessandrofelder force-pushed the brainrender-napari-tutorial-hotfixes branch from fcb0136 to 56b6612 Compare September 1, 2023 16:59
@alessandrofelder alessandrofelder marked this pull request as ready for review September 1, 2023 17:01
@adamltyson adamltyson merged commit 5a99adc into main Sep 4, 2023
2 checks passed
@adamltyson adamltyson deleted the brainrender-napari-tutorial-hotfixes branch September 4, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants