Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt brainrender-napari tutorial #225

Merged
merged 6 commits into from
Jul 30, 2024
Merged

adapt brainrender-napari tutorial #225

merged 6 commits into from
Jul 30, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jul 29, 2024 •
edited
Loading

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

The brainrender-napari tutorial is out-of-date.

What does this PR do?
Updates the docs to brainrender-napari 0.0.4 - this includes

  • adding an atlas-manager tutorial
  • adapting the atlas visualisation tutorial accordingly
  • the screenshot generation script to generate the images for the two tutorials above (this could be much improved, but not a priority for the core team right now?)

References

Closes #222

How has this PR been tested?

Local sphinx-build

Is this a breaking change?

No

Does this PR require an update to the documentation?

It is one

Checklist:

  • The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review July 29, 2024 15:29
adamltyson
adamltyson approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, just a couple of suggestions.

docs/source/documentation/brainglobe-atlasapi/usage/command-line-interface.md Show resolved Hide resolved
docs/source/tutorials/index.md Outdated Show resolved Hide resolved
docs/source/tutorials/index.md Outdated Show resolved Hide resolved
docs/source/tutorials/visualise-atlas-napari.md Show resolved Hide resolved
docs/source/tutorials/visualise-atlas-napari.md Outdated Show resolved Hide resolved
@alessandrofelder alessandrofelder merged commit b0be0a7 into main Jul 30, 2024
3 checks passed
@alessandrofelder alessandrofelder deleted the brainrender-manager-tutorial branch July 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamltyson adamltyson adamltyson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] brainrender-napari tutorial is out-of-date
2 participants
@alessandrofelder @adamltyson